jonnybot0 commented on code in PR #277:
URL: https://github.com/apache/groovy-geb/pull/277#discussion_r2178633690
##########
settings.gradle:
##########
@@ -23,6 +23,12 @@ plugins {
// updating this, check the compatibility from
https://docs.gradle.com/enterprise/compatibility/#develocity_compatibility and
https://develocity.apache.org/scans.
id "com.gradle.develocity" version "3.18.2"
id 'com.gradle.common-custom-user-data-gradle-plugin' version '2.0.2'
+ // The Ratpack server providing the gem repository uses classes from
+ // jakarta.activation-api.jar brought in here by
org.kordamp.gradle.oci-build-cache
+ // but the classes in there cannot work properly as classes from
+ // the activation implementation are missing, so bring the plugin
+ // to the classpath here to fix compatibility problems
+ id 'org.asciidoctor.jvm.gems' version '4.0.4' apply false
Review Comment:
Okay, I can reproduce the issue. I still don't love this change, as it just
seems smelly. It seems like either the upstream plugin isn't doing a good job
managing its dependencies or we aren't.
That said... it ain't that bad. :) I assume this is all in the service of
using the `asciidoctor-tabs` gem, which seems worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
