On Thu, 2008-10-02 at 12:52 -0500, Kipton Moravec wrote:
> I do not think so. Here is the code.
>
> #ifdef HAVE_SNPRINTF
> snprintf(tmpName, MAX_TEXTLEN, "netname");
> snprintf(tmpValue, MAX_TEXTLEN, "NC");
> #else
> snprintf(tmpName, "netname");
> sprintf(tmpValue, "NC");
> #endif
Ok, your fix looks good. I'll push it in to the repository. Can I use
this email address as the contact detail? :
commit 1cc8b302b934ff2571f70d664afa9e6faa5fd66e
Author: Kipton Moravec <[EMAIL PROTECTED]>
Date: Thu Oct 2 20:05:58 2008 +0100
utils/convert_sym: Fixed typo causing build failure without snprintf
Your first commit in the gEDA repository ;). (Git has a model where the
Author / committer are both logged, so I can acknowledge your patch,
even if it is me who pushes it into the repository).
> I guess if HAVE_SNPRINTF is defined it would never hit the bad code.
I can't think of any case where we dance around testing for that
function. I wonder what OS the #if ... block was intended to fix.
[snip]
> configure: error: libgeda detection error: Requested 'libgeda >=
> 20080929' but version of libgeda is 20080127
>
>
> I got an error in configure on the version. Is that a deal breaker?
You'll need to install the development headers for libgeda - from
wherever you got the package. Ideally, you're working from the same
version of sources as you've got on your machine, and you can just use
that. Otherwise, just grab the sources and build the whole suite.
BTW.. Grabbing the suite via git is easier than installing and building
lots of separate tarballs.
git clone git://git.gpleda.org/gaf.git
That is going to be the latest development code. You might want to do:
git checkout -b 1.4.1 1.4.1-20080929
(Creates a local branch called 1.4.1 which pulls in code from our
1.4.1-20080929 tagged release).
(Or run the development code, if you fancy being a beta-tester ;). In
that case, you're already on the right piece of code with the "master"
branch git clone will setup).
--
Peter Clifton
Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA
Tel: +44 (0)7729 980173 - (No signal in the lab!)
_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
