Peter Clifton wrote:
> On Thu, 2008-10-02 at 12:52 -0500, Kipton Moravec wrote:
>   
>> I do not think so. Here is the code.
>>
>> #ifdef HAVE_SNPRINTF
>>     snprintf(tmpName, MAX_TEXTLEN, "netname");
>>     snprintf(tmpValue, MAX_TEXTLEN, "NC");
>> #else
>>     snprintf(tmpName, "netname");  
>>     sprintf(tmpValue, "NC");
>> #endif
>>     
>
> [SNIP]
>> I guess if HAVE_SNPRINTF is defined it would never hit the bad code.
>>     
>
> I can't think of any case where we dance around testing for that
> function. I wonder what OS the #if ... block was intended to fix.
>
> [snip]
>
>   
I think I put that in there sooo long ago to either support an ancient 
Sunos or old FreeBSD installation.  'snprintf()' is ISO C99, so wasn't 
universally present when I wrote the code. (Has it really been almost 9 
years...)

Not sure where the 'n' snuck in on the #else case though, that's clearly 
a typo.  Thanks for pushing this.


_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev

Reply via email to