On Wed, 2008-10-08 at 21:00 +0200, Werner Hoch wrote: > Yes but I'm iterating over the whole object list multiple times. > (once for each string in the filter list).
I didn't notice that. You're right - some kind of filtering would perhaps be better, although as an implementation detail, I'd guess that just iterates over each name to filter against for each object it encounters. (Roughly the same complexity, possibly better cache usage?) > Thus filtering out all attributes from the symbol once and then just > loop over this short list is much better. (2 commits of attr2 branch) > > http://repo.or.cz/w/geda-gaf/werner.git?a=shortlog;h=refs/heads/attr2 > > BTW.. Is there any case you know of where you actually _want_ to > > filter out any of the toplevel attributes? > > The filter list sorts the attributes, too. This is even the main reason > why I've created the filter list. Use the tree sortable model. Example code in the component selector, PCB's component selector, netlist view, ... (See GtkTreeModelSort.) > Nice ideas. Thanks for tolerating my bike-shedding. Best wishes. -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
