On Sunday 26 October 2008 07:57:06 Werner Hoch wrote:

> > I wondered brieflyy about using an expander button to show/hide the
> > attributes section of the dialog, but I'm not sure how busy that will
> > feel with an VPaned as well. (I'd not like to loose the ability to
> > resize that portion of the dialog).
> >
> > I'm also tempted to see what it looks like with the attribute preview
> > list tucked under the graphic preview, with the component list
> > retaining the full height of the screen.
>
> The most interesting attributes (description, documentation) are quite
> long. They fit fine below the two other widgets.
>
> I'm wondering whether we should just remove the table caption to save
> some space.
>
> Let's just see, what other users think about that. I'm pushing the
> changes to the git repo.

A few comments:

1. Sorry, Werner, the table takes up too much space relative to the library
   tree view in that configuration, making the component library pretty
   unusable on an 800-pixel-high screen (if you want to be able to see the
   schematic as well).

2. I notice that you're filtering the list on the
   option 'component-dialog-attributes', and that can take symbolic arguments.
   Just to make my life easier as I rework the config system: could you please
   make it take *only* a list of strings? Perhaps allow wildcards, so
   (component-dialog-attributes '("*")) would have the same effect as
   (component-dialog-attributes '(*)) currently does with your special-casing. 

   See: http://www.gtk.org/api/2.6/glib/glib-Glob-style-pattern-matching.html

   Doing it with globs also allows me to do "stockid-*" to show the stock
   numbers for all my favourite vendors!

   Alternatively, I'm considering adding PCRE to libgeda's deps after 2.6...
   *waits for massive outcry* ...so you could then go back to just specifying
   a string.

   (component-dialog-attributes "(attrib1|attrib1|stockid-.*)")

3. Consider whether it would be good to distinguish between promotable and
   non-promotable attributes in some way.

Other than that, it looks good.

Peter

-- 
Peter Brett

Electronic Systems Engineer
Integral Informatics Ltd

Attachment: signature.asc
Description: This is a digitally signed message part.


_______________________________________________
geda-dev mailing list
[email protected]
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev

Reply via email to