Hi Peter, On Donnerstag, 9. Oktober 2008, Peter Clifton wrote: > On Thu, 2008-10-09 at 11:07 +0100, Peter Clifton wrote: > > > Peter, can you review the whole feature? I think it's complete > > > now. > > > > I'll pull your code, rebase on top of the cario + local_mods I'm > > running as "production code", so I'll end up using the code over > > the next day or so. It looks good to the eye. > > Comments from having tried the code: > > Need to add settings-save code to make the vpaned widget store its > position. I've attached a suggested* patch.)
I've added that patch. > (* Although I'm now wondering if naming the settings "hpaned" and > "vpaned" is in retrospect a good idea - in case anyone wants to > change the layout of this dialog in the future, using more of these > widgets. I could have named them more explicitly as to what they > separate etc.) It's not that bad (at least for the programmers). Even if you move the attribute list below the preview, it's still vpaned ;-) > I wondered brieflyy about using an expander button to show/hide the > attributes section of the dialog, but I'm not sure how busy that will > feel with an VPaned as well. (I'd not like to loose the ability to > resize that portion of the dialog). > I'm also tempted to see what it looks like with the attribute preview > list tucked under the graphic preview, with the component list > retaining the full height of the screen. The most interesting attributes (description, documentation) are quite long. They fit fine below the two other widgets. I'm wondering whether we should just remove the table caption to save some space. Let's just see, what other users think about that. I'm pushing the changes to the git repo. Regards Werner _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
