On Thu, 17 Feb 2005 22:25:58 +0100, Werner Hoch <[EMAIL PROTECTED]> wrote:
> I've used this patch to replace g_setenv.
> Please take a look at it, I'm a little out of practice.
two small suggestions:
* "cvs diff -u" will give a bit of context to the lines you changed.
* strlen("GEDADATA=\0") and strlen("GEDADATA=") both should return the
same value, even though the first string constant has an extra byte.
(The compiler automatically terminates string constants with a '\0'
character.) You're correct to add one to the lengths when allocating
memory dynamically, but for clarity I'd drop the '\0' in the strings
(unless I misunderstood what you're trying to do.)
regards,
--
- Charles Lepple
