-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hello folks,
Am Mo den 2. Mai 2011 um 17:42 schrieb Omari Stephens: > Howdy, all. It's time for a thought on code cleanliness :-) That is my objective to. > 2) We need to have a maximum line length. It can be long, sure, but > it's pretty obscene when there are lines so long that they wrap on my > 26" widescreen monitor (layout_util.c is a pretty bad offender). I'm > going to suggest 160 characters; see * below. Well, personally I do not care about maximum line length. And I prefer long lines over to short lines. (Not to mean that long lines are preferable but short broken down lines are horrible to read.) 160 characters are ok for me. > 3) Indentation. First, we should probably document the size of the tabs > (currently 8 characters, at least from the one file I'm looking at). See also the vim modeline in the source files, yes. > Secondly, it would take a lot of effort to switch, but I think we should > at least consider a more compact indentation format. I'm personally a > fan of 4 spaces. But I think that the width of our indents is a > contributing factor to the immense lengths of lines in our code. I myself prefer to have an indent of 3 spaces. But however, that is personal preferences. I'll add one point. It would be nice if we have something like a map that shows which code parts are involved in which part of the UI. The most time I spend is searching where that particular function is implemented. This is more complicate with the asynchrony design of GUIs like GTK. (QT and other are not better ...) That was one of the reasons I once think of redesigning the GUI part with glade. But that was much to much to get finished in recent times. Regards Klaus - -- Klaus Ethgen http://www.ethgen.ch/ pub 2048R/D1A4EDE5 2000-02-26 Klaus Ethgen <kl...@ethgen.de> Fingerprint: D7 67 71 C4 99 A6 D4 FE EA 40 30 57 3C 88 26 2B -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEVAwUBTb7/65+OKpjRpO3lAQpnMQf+LOboAeTd15o8SSXvZ1lReNLJJduizKyd kM+Yuuz0XUVIkKw74PbIoYveKtQMr7mCCmjdB2zFZOX0Uwlgn0P6rGeRHuqiXyoS oVBBgeYP4/daH6IAtARwhqxAOZ5q+LsOQAf7NOI8ig/IFpHT8Jspbz6xDNT/gTqO hXIeL1bAq7D8iGUP1DktXVoKNa9oyA9BVCojRKkpfeYfTrCvXLbpz4JpxOZuTViM ZMk3h4zfPXsaftUaHUCiY21YAYU7ZOTgdBoC9EB1wxWZ2SFs72AL8OUkyZjgQNE3 qjK47fIvypOQ1Zu6qSdX9wvbkMnam3zRBBbMOClpUOdin07KcIeqlg== =+VVE -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
