Hi
Perhaps I could make some comments here not as a developer, but as a user.
1) It's probably a good idea for us to start documenting the functions
we write and the APIs we create.  For one, it's a reminder to think
about what specific problems the function/API is solving.  Beyond that,
it helps someone unfamiliar with the code figure out what's going on,
and it helps them avoid misusing a particular function.
What I find missing is high-level documentation, not low-level. An overall description of the way the system is organised and how the main functions and structures should be used. But in my experience, programmers won't produce documentation even when they are being paid to do it, and no-one is being paid to work on Geeqie. Being realistic, I don't think it is reasonable to expect people to do this.
2) We need to have a maximum line length.  It can be long, sure, but
it's pretty obscene when there are lines so long that they wrap on my
26" widescreen monitor (layout_util.c is a pretty bad offender).  I'm
going to suggest 160 characters; see * below.

Line length was important to me when I used 72-character terminals nearly half a century ago. Now I use a visual editor with line-wrap enabled. No matter what size window I use, the code is readable.

But I do find it very surprising that Geeqie has a non-standard coding format. Layout consistency could be achieved if the developers selected a standard format - maybe Allman or Whitesmith - and run all code through a code beautifier before putting it in the repository. Time spent on code formatting by hand is not a good use of time and will result in inconsistencies.


May I also make a plea for the common user, people like me who can just about do a configure/make.

Would it be possible for source tars (or even .deb files) of the latest files to be put on the Geeqie homepage on sourceforge? Is it possible for this do be done automatically whenever one of the git repositories is updated?


I would also encourage the developers to try to make Geeqie at least as good as GQview. There are two problems where I find GQview is significantly better than Geeqie:

During copy/move/rename there is no thumbnail displayed when there is a destination file conflict (I've made a patch to do this, which is ok for me, but it is a poor technical solution to the problem).

When I work with folders containing several thousand files, any operation on the files results in the view scrolling away from the area I am working on. I guess this is the same as bug *3107316*, and I assume it's because of gtktreeview being updated in the idle loop. But whatever, when I'm doing this kind of work I have to switch back to GQview!

But again, one must be realistic, and a combination of GQview and Geeqie works well for me as is.


Colin Clark..



------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Reply via email to