> On May 4, 2014, 4:56 p.m., Steve Reinhardt wrote: > > src/python/m5/simulate.py, line 117 > > <http://reviews.gem5.org/r/2246/diff/1/?file=39626#file39626line117> > > > > for all these 'if hasattr()' changes (here and below, and in > > simulate.py): seems like it would be much cleaner to make sure whatever > > dummy objects are being inserted into the config tree support dummy > > versions of these calls rather than add all these distributed checks all > > over the place. Maybe create a special DummySimObject class or something? > > I don't fully understand the use case here or perhaps I could be more > > specific.
BTW, is this change independent of the command-line parameter stuff? If so, then it should be a separate changeset. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2246/#review5082 ----------------------------------------------------------- On April 23, 2014, 5:22 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2246/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 5:22 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10198:f749128e94c8 > --------------------------- > config: Add hooks to enable new config sys > > This patch adds helper functions to SimObject.py, params.py and > simulate.py to enable the new configuration system. Functions like > enumerateParams() in SimObject lets the config system auto-generate > command line options for simobjects to be modified on the command > line. > > Params in params.py have __call__() added > to their definition to allow the argparse module to use them > as a type to check command input is in the proper format. > > simulate.py is changed to allow for empty simobjects to exist in the hierarchy > to allow a system to be built in parts to be stitched together later. > > > Diffs > ----- > > src/python/m5/SimObject.py e40b35147270 > src/python/m5/params.py e40b35147270 > src/python/m5/simulate.py e40b35147270 > src/python/m5/stats/__init__.py e40b35147270 > > Diff: http://reviews.gem5.org/r/2246/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
