> On May 4, 2014, 4:56 p.m., Steve Reinhardt wrote:
> > src/python/m5/SimObject.py, line 654
> > <http://reviews.gem5.org/r/2246/diff/1/?file=39624#file39624line654>
> >
> >     This seems kind of complicated, but I'm going to wait for a 
> > higher-level description of what it's doing before I dig into it.
> 
> Geoffrey Blake wrote:
>     The intent is that you can build a configuration system that exposes all 
> params to be settable on the command line (instead of the tiny fraction 
> available now) and a system that auto-updates its available settable command 
> line flags whenever a simobject's params are edited.  The other intention of 
> this function is to provide the argument parser with enough information about 
> each parameter to make unique command lines, and also use the ParamValue 
> itself as an input check to catch any errors in specifying a command as early 
> as possible.
>     
>     The enumerateParams() function takes a simobject instance and traces out 
> all the reachable parameters it contains and constructs information to be 
> presented on the command line.  For example, if you passed an instance of 
> O3_ARM_v7a_3 to enumerateParams() it will generate command lines to be 
> presented such as:
>     --testsys-cpucluster-O3_ARM_v7a_3.branchPred.BTBTagSize
>     --testsys-cpucluster-O3_ARM_v7a_3.fuPool.FUList0.count
>     --testsys-cpucluster-O3_ARM_v7a_3.LQEntries
>     
>     
>
> 
> Steve Reinhardt wrote:
>     OK, I see.  So I take it there's some additional code needed in 
> se.py/fs.py/etc. to make this work?  Would it make sense to include that in 
> this patch, so people can see how to use it?
> 
> Geoffrey Blake wrote:
>     There is a large chunk code that is a full top to bottom re-write of the 
> mainline configuration scripts, so it wouldn't make much sense to include in 
> this patch.

OK.  Are you intending to commit that separately then?


> On May 4, 2014, 4:56 p.m., Steve Reinhardt wrote:
> > src/python/m5/simulate.py, line 117
> > <http://reviews.gem5.org/r/2246/diff/1/?file=39626#file39626line117>
> >
> >     for all these 'if hasattr()' changes (here and below, and in 
> > simulate.py): seems like it would be much cleaner to make sure whatever 
> > dummy objects are being inserted into the config tree support dummy 
> > versions of these calls rather than add all these distributed checks all 
> > over the place. Maybe create a special DummySimObject class or something?  
> > I don't fully understand the use case here or perhaps I could be more 
> > specific.
> 
> Steve Reinhardt wrote:
>     BTW, is this change independent of the command-line parameter stuff?  If 
> so, then it should be a separate changeset.
> 
> Geoffrey Blake wrote:
>     Internally we had this discussion and it was deemed a worse maintenance 
> headache having a DummySimobject C++ class over being handled purely in the 
> python code.  It can be a separate changeset as well
> 
> Steve Reinhardt wrote:
>     You didn't invite me to your discussion ;).  It seems to me like we've 
> established what the SimObject interface is, and we've already added dummy 
> versions of these methods to the base SimObject class so that we don't have 
> to put all these tests in, even though many derived classes don't implement 
> them.  So a DummySimObject class ought to be pretty trivial, and putting in 
> all these tests now seems like a step backwards to me.
>     
>     As I said initially, I don't really understand the use case for these 
> "dummy objects" anyway, or how you can call simulate() when you don't have 
> all the objects in place yet, so maybe I'm missing something, but so far I 
> remain unconvinced.
> 
> Geoffrey Blake wrote:
>     The dummy simobject is being used as a means to provide naming resolution 
> only.  In the rewrite of the config scripts, it was a desired feature to have 
> functions that created whole subsystems that we could call multiple times to 
> instantiate the desired system:
>     
>     cluster1 = makeCpuAndCaches()
>     cluster2 = makeCpuAndCaches()
>     
>     SimObjects cluster1 and 2 would have identical sets of Simobjects as 
> children, but their final names would be unique (cluster1.cpu0.icache, 
> cluster2.cpu0.icache etc).  In the end Objects cluster1 and cluster2 aren't 
> instantiated (I have forgotten how now), but the simulated system still works 
> correctly because we made sure to connect up all the ports properly.  Making 
> an actual DummySimobject class is not hard, I did that in a previous 
> iteration.
> 
> Ali Saidi wrote:
>     My reasoning here was that we didn't really want to have a sim object 
> that was instantiated by did nothing, wasn't connected to anything and only 
> existed to provide containers for configuration.

That argument sounds reasonable on its own, but I feel like the consequences of 
following that path ultimately make it the least objectionable alternative.  
(IMO, being less objectionable than sprinkling 'hasattr' conditionals all over 
is a pretty low bar.)

It would be nice to avoid creating the useless C++ object if we could have the 
python object support the full SimObject interface, but that won't work because 
the python SimObject actually derives the interface dynamically from the C++ 
version (see SimObject.__getattr__).  So the C++ object isn't totally useless, 
in that it is serving as a proxy to export the C++ SimObject API out through 
the python code.

Also, if the purpose is to serve as a container, then a name like Container or 
SimObjectContainer seems more appropriate.


- Steve


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2246/#review5082
-----------------------------------------------------------


On April 23, 2014, 5:22 a.m., Andreas Hansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2246/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 5:22 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> Changeset 10198:f749128e94c8
> ---------------------------
> config: Add hooks to enable new config sys
> 
> This patch adds helper functions to SimObject.py, params.py and
> simulate.py to enable the new configuration system.  Functions like
> enumerateParams() in SimObject lets the config system auto-generate
> command line options for simobjects to be modified on the command
> line.
> 
> Params in params.py have __call__() added
> to their definition to allow the argparse module to use them
> as a type to check command input is in the proper format.
> 
> simulate.py is changed to allow for empty simobjects to exist in the hierarchy
> to allow a system to be built in parts to be stitched together later.
> 
> 
> Diffs
> -----
> 
>   src/python/m5/SimObject.py e40b35147270 
>   src/python/m5/params.py e40b35147270 
>   src/python/m5/simulate.py e40b35147270 
>   src/python/m5/stats/__init__.py e40b35147270 
> 
> Diff: http://reviews.gem5.org/r/2246/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to