> On June 28, 2015, 5:31 p.m., Nilay Vaish wrote: > > src/mem/cache/cache_impl.hh, lines 182-188 > > <http://reviews.gem5.org/r/2886/diff/1/?file=46271#file46271line182> > > > > What's going on over here that's related to the aim of the patch?
I have expanded the comment. We need to determine if the read came from a cache or not, and we do so by looking at the type of read command. The ones in the expression are from a cache. > On June 28, 2015, 5:31 p.m., Nilay Vaish wrote: > > src/mem/cache/cache_impl.hh, line 2145 > > <http://reviews.gem5.org/r/2886/diff/1/?file=46271#file46271line2145> > > > > Same question as previous one? Arguably, the new check is actually more sensible that what we had previously, since in cases where it was top level, but forward snoops was true it would have been more kosher to actually forward the snoop. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2886/#review6636 ----------------------------------------------------------- On June 10, 2015, 7:59 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2886/ > ----------------------------------------------------------- > > (Updated June 10, 2015, 7:59 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10877:5715b110f655 > --------------------------- > mem: Remove redundant is_top_level cache parameter > > This patch takes the final step in removing the is_top_level parameter > from the cache. With the recent changes to read requests and write > invalidations, the parameter is no longer needed, and consequently > removed. > > This also means that asymmetric cache hierarchies are now fully > supported (and we are actually using them already with L1 caches, but > no table-walker caches, connected to a shared L2). > > > Diffs > ----- > > configs/common/Caches.py ebb3d0737aa7 > configs/common/O3_ARM_v7a.py ebb3d0737aa7 > configs/example/memcheck.py ebb3d0737aa7 > configs/example/memtest.py ebb3d0737aa7 > src/mem/cache/BaseCache.py ebb3d0737aa7 > src/mem/cache/base.hh ebb3d0737aa7 > src/mem/cache/base.cc ebb3d0737aa7 > src/mem/cache/cache_impl.hh ebb3d0737aa7 > > Diff: http://reviews.gem5.org/r/2886/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
