> On June 28, 2015, 5:31 p.m., Nilay Vaish wrote: > > src/mem/cache/cache_impl.hh, line 2145 > > <http://reviews.gem5.org/r/2886/diff/1/?file=46271#file46271line2145> > > > > Same question as previous one? > > Andreas Hansson wrote: > Arguably, the new check is actually more sensible that what we had > previously, since in cases where it was top level, but forward snoops was > true it would have been more kosher to actually forward the snoop. > > Nilay Vaish wrote: > So now you will forward the snoop to the cpu? What does that mean? > Instead, should you not mark forward_snoops as False for L1 caches?
You must indeed forward snoops to the core. This is needed for the synchronisation operations stored in the LSQ. This has always been the case. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2886/#review6636 ----------------------------------------------------------- On June 29, 2015, 9:43 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2886/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 9:43 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10887:9be908d7c501 > --------------------------- > mem: Remove redundant is_top_level cache parameter > > This patch takes the final step in removing the is_top_level parameter > from the cache. With the recent changes to read requests and write > invalidations, the parameter is no longer needed, and consequently > removed. > > This also means that asymmetric cache hierarchies are now fully > supported (and we are actually using them already with L1 caches, but > no table-walker caches, connected to a shared L2). > > > Diffs > ----- > > configs/common/Caches.py 73d4798871a5 > configs/common/O3_ARM_v7a.py 73d4798871a5 > configs/example/memcheck.py 73d4798871a5 > configs/example/memtest.py 73d4798871a5 > src/mem/cache/BaseCache.py 73d4798871a5 > src/mem/cache/base.hh 73d4798871a5 > src/mem/cache/base.cc 73d4798871a5 > src/mem/cache/cache_impl.hh 73d4798871a5 > > Diff: http://reviews.gem5.org/r/2886/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
