----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/751/#review1344 -----------------------------------------------------------
Seems that this change should be merged with the other one. They seem to be interdependent. src/cpu/base_dyn_inst.hh <http://reviews.m5sim.org/r/751/#comment1798> Seems that these particular functions are fine to me. It's the ones with the switch statements that are not useful. src/cpu/base_dyn_inst.hh <http://reviews.m5sim.org/r/751/#comment1797> Does the tracing get lost? - Nathan On 2011-06-20 11:44:00, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/751/ > ----------------------------------------------------------- > > (Updated 2011-06-20 11:44:00) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ExecContext: Get rid of the now unused read/write templated functions. > > > Diffs > ----- > > src/cpu/base_dyn_inst.hh f12d1cd32cc7 > src/cpu/exec_context.hh f12d1cd32cc7 > src/cpu/inorder/inorder_dyn_inst.hh f12d1cd32cc7 > src/cpu/inorder/inorder_dyn_inst.cc f12d1cd32cc7 > src/cpu/simple/atomic.hh f12d1cd32cc7 > src/cpu/simple/atomic.cc f12d1cd32cc7 > src/cpu/simple/timing.hh f12d1cd32cc7 > src/cpu/simple/timing.cc f12d1cd32cc7 > > Diff: http://reviews.m5sim.org/r/751/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
