> On 2011-07-02 09:21:11, Steve Reinhardt wrote: > > src/arch/power/isa/formats/mem.isa, line 136 > > <http://reviews.m5sim.org/r/655/diff/4/?file=13256#file13256line136> > > > > val doesn't seem to be used anywhere else; why not get rid of it and > > rewrite this as: > > > > getMem(pkt, *((%(mem_acc_type)s*)&Mem), traceData); > > > > Is there any case where Mem is not of mem_acc_type? If not, it could > > be a lot simpler even...
I agree this code is probably overly complicated (there's some like that in SPARC too) but I wanted this to be a 1:1 translation and to avoid doing anything that would actually change the code (for better or for worse). It probably can be simplified, and I'll put together a later change for it. Other than that is this alright? - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/655/#review1383 ----------------------------------------------------------- On 2011-07-02 02:23:04, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/655/ > ----------------------------------------------------------- > > (Updated 2011-07-02 02:23:04) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ISA parser: Simplify operand type handling. > > This change simplifies the code surrounding operand type handling and makes it > depend only on the ctype that goes with each operand type. Future changes will > allow defining operand types by their ctypes directly, convert the ISAs over > to that style of definition, and then remove support for the old style. These > changes are to make it easier to use non-builtin types like classes or > structures as the type for operands. > > > Diffs > ----- > > src/arch/isa_parser.py 4adb1148ef73 > src/arch/power/isa/formats/mem.isa 4adb1148ef73 > > Diff: http://reviews.m5sim.org/r/655/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
