----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/799/#review1445 -----------------------------------------------------------
Ship it! So apparently this was not used anywhere? - Steve On 2011-07-19 02:19:13, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/799/ > ----------------------------------------------------------- > > (Updated 2011-07-19 02:19:13) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > O3: Get rid of the raw ExtMachInst constructor on DynInsts. > > This constructor assumes that the ExtMachInst can be decoded directly into a > StaticInst that's useful to execute. With the advent of microcoded > instructions that's no longer true. > > > Diffs > ----- > > src/cpu/base_dyn_inst.hh 82ff928182c5 > src/cpu/base_dyn_inst_impl.hh 82ff928182c5 > src/cpu/o3/dyn_inst.hh 82ff928182c5 > src/cpu/o3/dyn_inst_impl.hh 82ff928182c5 > src/cpu/ozone/dyn_inst_impl.hh 82ff928182c5 > > Diff: http://reviews.m5sim.org/r/799/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
