----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/836/#review1487 -----------------------------------------------------------
Ship it! seems fine, but I would like some comments src/arch/x86/insts/microop.hh <http://reviews.m5sim.org/r/836/#comment1987> I think a couple of comments are very much needed here for why you're doing this and what you're actually doing. Took me a little bit to figure out that you're creating a 32bit bit set for each 32 bits and oring them together. FYI, this is fixed in C++0x - Ali On 2011-09-04 19:45:31, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/836/ > ----------------------------------------------------------- > > (Updated 2011-09-04 19:45:31) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > X86: Make sure instruction flags are set properly even on 32 bit machines. > > The way flag bits were being set for microops in x86 ended up implicitly > calling the bitset constructor which was truncating flags beyond the width of > an unsigned long. This change sets the bits in chunks which are always small > enough to avoid being truncated. On 64 bit machines this should reduce to be > the same as before, and on 32 bit machines it should work properly and not be > unreasonably inefficient. > > > Diffs > ----- > > src/arch/x86/insts/microop.hh 09745e0c3dd9 > > Diff: http://reviews.m5sim.org/r/836/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
