Whoops, I just realized I never got back to your comments on this
review, Ali. This is checked in so it's a little late, but responses are
below.

On 09/04/11 09:27, Ali Saidi wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/828/#review1482
> -----------------------------------------------------------
>
>
> Assuming there are no stats changes, it seems fine. 
>
>
> src/cpu/o3/fetch.hh
> <http://reviews.m5sim.org/r/828/#comment1983>
>
>     This comment is nearly useless. 

Yes, but it's consistently useless :-). There are other similar comments
in this file, and I was blending in.

>
>
> src/cpu/simple/base.cc
> <http://reviews.m5sim.org/r/828/#comment1984>
>
>     Have you looked at the performance difference here?

No. I expect if it exists at all it would be negligible.

>
> - Ali
>
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to