----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/854/#review1529 -----------------------------------------------------------
I agree with Ali that this and the other byteswap.hh change should be combined. Also it seems odd that, combining these two patches, you're getting rid of ByteOrderDiffers since it's not used, but you're adding a GuestByteOrder constant that's also not (yet) used... is there a specific place where you're needing this? - Steve On 2011-09-11 19:03:55, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/854/ > ----------------------------------------------------------- > > (Updated 2011-09-11 19:03:55) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Endianness: Make it easier to check the compiled in guest endianness. > > It was technically possible but clumsy to determine what endianness a guest > was configured with using the state in byteswap.hh. This change makes that > information available more directly. > > > Diffs > ----- > > src/sim/byteswap.hh 2862c39f66f8 > > Diff: http://reviews.m5sim.org/r/854/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
