> On 2011-09-12 08:53:52, Steve Reinhardt wrote: > > I agree with Ali that this and the other byteswap.hh change should be > > combined. > > > > Also it seems odd that, combining these two patches, you're getting rid of > > ByteOrderDiffers since it's not used, but you're adding a GuestByteOrder > > constant that's also not (yet) used... is there a specific place where > > you're needing this?
Ok, I'll merge them. The primary reason they're separate is that I discovered I needed the new constant first and created that change. Then when I was testing I wanted to be sure to run the ISA that used ByteOrderDiffers, but then I discovered that there wasn't one and spun up the second patch. The place it's used is here: http://reviews.m5sim.org/r/858/ It's interesting to note there that the code was incorrectly checking the *host* order to decide what the instruction should do instead of checking the guest order. In any case it should have been using the constants defined in byteswap.hh instead of the macros. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/854/#review1529 ----------------------------------------------------------- On 2011-09-11 19:03:55, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/854/ > ----------------------------------------------------------- > > (Updated 2011-09-11 19:03:55) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Endianness: Make it easier to check the compiled in guest endianness. > > It was technically possible but clumsy to determine what endianness a guest > was configured with using the state in byteswap.hh. This change makes that > information available more directly. > > > Diffs > ----- > > src/sim/byteswap.hh 2862c39f66f8 > > Diff: http://reviews.m5sim.org/r/854/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
