[gem5-dev] changeset in gem5: Faults: Get rid of the unused isAlignmentFaul...

[Gabe Black]

changeset 498d3aacd292 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=498d3aacd292
description:
        Faults: Get rid of the unused isAlignmentFault and isMachineCheckFault.

        These functions aren't called anywhere and are probably only 
theoretically
        useful.

diffstat:

 src/arch/alpha/faults.hh |   1 -
 src/arch/power/faults.hh |   6 ------
 src/arch/sparc/faults.hh |  12 ++----------
 src/sim/faults.hh        |   2 --
 4 files changed, 2 insertions(+), 19 deletions(-)

diffs (68 lines):

diff -r 83f728db3332 -r 498d3aacd292 src/arch/alpha/faults.hh
--- a/src/arch/alpha/faults.hh  Mon Sep 19 06:17:19 2011 -0700
+++ b/src/arch/alpha/faults.hh  Mon Sep 19 06:17:20 2011 -0700
@@ -68,7 +68,6 @@
     FaultName name() const {return _name;}
     FaultVect vect() {return _vect;}
     FaultStat & countStat() {return _count;}
-    bool isMachineCheckFault() const {return true;}
 };
 
 class AlignmentFault : public AlphaFault
diff -r 83f728db3332 -r 498d3aacd292 src/arch/power/faults.hh
--- a/src/arch/power/faults.hh  Mon Sep 19 06:17:19 2011 -0700
+++ b/src/arch/power/faults.hh  Mon Sep 19 06:17:20 2011 -0700
@@ -83,12 +83,6 @@
         : PowerFault("Alignment")
     {
     }
-
-    bool
-    isAlignmentFault() const
-    {
-        return true;
-    }
 };
 
 
diff -r 83f728db3332 -r 498d3aacd292 src/arch/sparc/faults.hh
--- a/src/arch/sparc/faults.hh  Mon Sep 19 06:17:19 2011 -0700
+++ b/src/arch/sparc/faults.hh  Mon Sep 19 06:17:20 2011 -0700
@@ -139,11 +139,7 @@
 class DivisionByZero : public SparcFault<DivisionByZero> {};
 
 class InternalProcessorError :
-    public SparcFault<InternalProcessorError>
-{
-  public:
-    bool isMachineCheckFault() const { return true; }
-};
+    public SparcFault<InternalProcessorError> {};
 
 class InstructionInvalidTSBEntry :
     public SparcFault<InstructionInvalidTSBEntry> {};
@@ -159,11 +155,7 @@
 class DataAccessProtection : public SparcFault<DataAccessProtection> {};
 
 class MemAddressNotAligned :
-    public SparcFault<MemAddressNotAligned>
-{
-  public:
-    bool isAlignmentFault() const { return true; }
-};
+    public SparcFault<MemAddressNotAligned> {};
 
 class LDDFMemAddressNotAligned : public SparcFault<LDDFMemAddressNotAligned> 
{};
 
diff -r 83f728db3332 -r 498d3aacd292 src/sim/faults.hh
--- a/src/sim/faults.hh Mon Sep 19 06:17:19 2011 -0700
+++ b/src/sim/faults.hh Mon Sep 19 06:17:20 2011 -0700
@@ -57,8 +57,6 @@
     virtual FaultName name() const = 0;
     virtual void invoke(ThreadContext * tc,
             StaticInstPtr inst = StaticInst::nullStaticInstPtr);
-    virtual bool isMachineCheckFault() const {return false;}
-    virtual bool isAlignmentFault() const {return false;}
 };
 
 class UnimpFault : public FaultBase
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev