----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/834/#review1555 -----------------------------------------------------------
Overall this looks like a really good start... given that I don't know pytest at all, it's hard to be confident, but once you get to something that works and we can play around with it we should be able to provide more concrete feedback. Looks like you're headed in the right direction to me though. new_tests/conftest.py <http://reviews.m5sim.org/r/834/#comment2039> Should canonical_name include sname? Looks like below wherever you use canonical_name you're explicitly including sname too. new_tests/conftest.py <http://reviews.m5sim.org/r/834/#comment2045> as I mention below, I'd prefer to see us use the existing configs/example scripts by default, so it might be nice to build a command line here that doesn't directly involve the test infrastructure (other than locating inputs and outputs) new_tests/conftest.py <http://reviews.m5sim.org/r/834/#comment2044> this func name is a little misleading... sounds like it might actually run the test here new_tests/conftest.py <http://reviews.m5sim.org/r/834/#comment2040> I don't have a problem with hardwiring standard output filenames like stats.txt or simout... these are going to be run under a controlled environment, so they won't change from test to test, and making them variable just obscures what's going on IMO. new_tests/conftest.py <http://reviews.m5sim.org/r/834/#comment2041> Yea, we can either fork the existing perl script or port it to python... the perl code works, fwiw. new_tests/hello_world/test_hello.py <http://reviews.m5sim.org/r/834/#comment2043> I'd really like to see the regressions use the config scripts in configs/example, if possible; that way those scripts get included in the testing, and we don't have redundant config code just for tests. - Steve On 2011-08-30 10:48:42, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/834/ > ----------------------------------------------------------- > > (Updated 2011-08-30 10:48:42) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Regressions: Start of new regression system > > This code is to start a discussion around how to implement the next > regression system for gem5. Attached is a simple example that doesn't > run gem5 yet, but is getting closer. The big question here is how to > build up configuration files to hopefully minimize duplication of code. > > > Diffs > ----- > > new_tests/conftest.py PRE-CREATION > new_tests/hello_world/test_hello.py PRE-CREATION > > Diff: http://reviews.m5sim.org/r/834/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
