> On 2011-09-21 22:19:38, Steve Reinhardt wrote: > > new_tests/conftest.py, line 81 > > <http://reviews.m5sim.org/r/834/diff/1/?file=14762#file14762line81> > > > > as I mention below, I'd prefer to see us use the existing > > configs/example scripts by default, so it might be nice to build a command > > line here that doesn't directly involve the test infrastructure (other than > > locating inputs and outputs)
So I actually played with this some more recently and got hello world working running from the command line. However, the process convinced me that we don't actually want to run gem5 from the command line via the existing scripts. Perhaps there should be regression tests that do, but they should exist to test the config scripts and not be a requirement for all tests. The primary reason I came to this conclusion is that we throw a lot of information away when placing things on the command line and we don't get to have error handling in python scripts communicate information back to the simulator in a nice way. For example, we've talked a lot about if a input file doesn't exist we should skip the test (as opposed to reporting pass or fail). If we look at how cpu2000.py handles files not found it raises an exception. This flows back to se.py where we panic on the exception. I think it would be much nicer if the test infrastructure caught the exception when the LiveProcess was being created as opposed to trying to do some string matching on stderr or perhaps defining certain return codes that means "input file not found." Thoughts? - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/834/#review1555 ----------------------------------------------------------- On 2011-08-30 10:48:42, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/834/ > ----------------------------------------------------------- > > (Updated 2011-08-30 10:48:42) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Regressions: Start of new regression system > > This code is to start a discussion around how to implement the next > regression system for gem5. Attached is a simple example that doesn't > run gem5 yet, but is getting closer. The big question here is how to > build up configuration files to hopefully minimize duplication of code. > > > Diffs > ----- > > new_tests/conftest.py PRE-CREATION > new_tests/hello_world/test_hello.py PRE-CREATION > > Diff: http://reviews.m5sim.org/r/834/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
