> On 2011-10-10 19:21:39, Gabe Black wrote: > > I'm sorry if I haven't been paying attention, but what do these changes > > have to do with QEMU? > > Nilay Vaish wrote: > I should have been more elaborate. The io ports assigned to Ide Disk are > different from the those assigned in QEMU. Specifically QEMU assigns > IDE BAR 1 to be 3f6 instead of 3f4 as it is in gem5 right now. The size > is 1 in place of 3. > > I would expect these ports to be same for both gem5 and QEMU.
I would agree that these should be the same, though the question is, why did you do this? Was there a bug? I assume that linux didn't work and this fixed it, but your commit message wasn't exactly clear (it may also mean that you simply tested it with that kernel version). Finally, you added a dma controller. What was that for? Overall, the change seems fine and should probably go in, just a bit confused as to what it is for. - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/890/#review1594 ----------------------------------------------------------- On 2011-10-10 17:55:10, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/890/ > ----------------------------------------------------------- > > (Updated 2011-10-10 17:55:10) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > IDE Disk: Bring it inline with QEMU > I have made some changes to the IDE Disk's ports so that it is inline with > QEMU. I am able to boot Linux 2.6.28.4 for x86 with these changes. > > > Diffs > ----- > > src/dev/ide_ctrl.cc 30a97c4198df > src/dev/ide_disk.hh 30a97c4198df > src/dev/ide_disk.cc 30a97c4198df > src/dev/x86/SouthBridge.py 30a97c4198df > > Diff: http://reviews.m5sim.org/r/890/diff > > > Testing > ------- > > > Thanks, > > Nilay > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
