Well, if the ctrlOffset part fixes a bug that would be good to check in still. I'm ok with the second DMA controller too, but that may break existing x86 checkpoints somehow? Not sure about that.
Gabe On 10/16/11 21:23, Nilay Vaish wrote: > >> On 2011-10-16 02:02:54, Gabe Black wrote: >>> src/dev/x86/SouthBridge.py, line 76 >>> <http://reviews.m5sim.org/r/890/diff/1/?file=15285#file15285line76> >>> >>> I don't think these changes to the BARs are correct, and I don't see >>> why this would matter when restoring a checkpoint. > You are right. I checked the Linux kernel today. It seems to use > both 0x3f4 and 0x3f6. Hence, I will not be committing this patch. > > > - Nilay > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/890/#review1605 > ----------------------------------------------------------- > > > On 2011-10-10 17:55:10, Nilay Vaish wrote: >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.m5sim.org/r/890/ >> ----------------------------------------------------------- >> >> (Updated 2011-10-10 17:55:10) >> >> >> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and >> Nathan Binkert. >> >> >> Summary >> ------- >> >> IDE Disk: Bring it inline with QEMU >> I have made some changes to the IDE Disk's ports so that it is inline with >> QEMU. I am able to boot Linux 2.6.28.4 for x86 with these changes. >> >> >> Diffs >> ----- >> >> src/dev/ide_ctrl.cc 30a97c4198df >> src/dev/ide_disk.hh 30a97c4198df >> src/dev/ide_disk.cc 30a97c4198df >> src/dev/x86/SouthBridge.py 30a97c4198df >> >> Diff: http://reviews.m5sim.org/r/890/diff >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Nilay >> >> > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
