----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/902/#review1635 -----------------------------------------------------------
After a mostly superficial look through it seems pretty good, other than a few minor style nits. This looks pretty familiar. Did this already get posted for review? I think this is Nate's stuff, so we should wait to hear from him before committing anything. src/base/output.hh <http://reviews.m5sim.org/r/902/#comment2111> Functions shouldn't have the { on the same line as the function name. src/base/output.cc <http://reviews.m5sim.org/r/902/#comment2112> This shouldn't all be one line. src/base/output.cc <http://reviews.m5sim.org/r/902/#comment2113> Should this be a fatal or panic? I guess it depends on if the bad choice of directory was gem5's fault or the users. I don't think this is wrong or right, just wanted to point it out. - Gabe On 2011-11-03 13:29:20, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/902/ > ----------------------------------------------------------- > > (Updated 2011-11-03 13:29:20) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Output: Add hierarchical output support and cleanup existing codebase. > > > Diffs > ----- > > src/base/output.hh 5fb918115c07 > src/base/output.cc 5fb918115c07 > src/base/stats/text.cc 5fb918115c07 > src/cpu/base.cc 5fb918115c07 > src/dev/terminal.cc 5fb918115c07 > > Diff: http://reviews.m5sim.org/r/902/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
