> On 2011-11-06 01:06:41, Gabe Black wrote: > > After a mostly superficial look through it seems pretty good, other than a > > few minor style nits. This looks pretty familiar. Did this already get > > posted for review? I think this is Nate's stuff, so we should wait to hear > > from him before committing anything.
Yes a long time ago, but the feedback was to chop it in 2 pieces. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/902/#review1635 ----------------------------------------------------------- On 2011-11-03 13:29:20, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/902/ > ----------------------------------------------------------- > > (Updated 2011-11-03 13:29:20) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Output: Add hierarchical output support and cleanup existing codebase. > > > Diffs > ----- > > src/base/output.hh 5fb918115c07 > src/base/output.cc 5fb918115c07 > src/base/stats/text.cc 5fb918115c07 > src/cpu/base.cc 5fb918115c07 > src/dev/terminal.cc 5fb918115c07 > > Diff: http://reviews.m5sim.org/r/902/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
