----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/911/#review1673 -----------------------------------------------------------
This change looks right, although I haven't looked at it really closely. Thank you for sharing your fix with us. Your commit message isn't in the right format, though. It's not at all obvious, but there's a brief explanation of what it should look like under "Details" here: http://www.gem5.org/Commit_Access Also, you should run the SPARC_FS regressions since that's where the devices are used. - Gabe On 2011-11-24 10:06:40, Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/911/ > ----------------------------------------------------------- > > (Updated 2011-11-24 10:06:40) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Fixing a minor bug in the mm_disk implementation where a copy paste > error resulted in the d32 variable not being initialised (as it > incorrectly was used instead of d16), and gcc 4.5 complaining. > > > Diffs > ----- > > src/dev/sparc/mm_disk.cc 62dee0c98d53 > > Diff: http://reviews.m5sim.org/r/911/diff > > > Testing > ------- > > All SPARC_SE opt pass > > > Thanks, > > Andreas > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
