> On 2011-11-25 11:34:39, Ali Saidi wrote: > > Since we don't have a working sparc FS regression, nor do people without > > access to zizze have a file system, this will have to do.
Yes, I agree. The change looks very reasonable so I'm confident it's correct, but I'll run it myself just to be sure. Do you have commit access, or do you need somebody to put it in for you? - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/911/#review1674 ----------------------------------------------------------- On 2011-11-25 05:19:59, Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/911/ > ----------------------------------------------------------- > > (Updated 2011-11-25 05:19:59) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > SPARC: Fixing a minor copy-paste bug using the wrong variable > > There was a bug in the mm_disk implementation where a copy paste error > resulted in the d32 variable not being initialised (as it incorrectly > was used instead of d16), and gcc 4.5 complaining. > > > Diffs > ----- > > src/dev/sparc/mm_disk.cc 62dee0c98d53 > > Diff: http://reviews.m5sim.org/r/911/diff > > > Testing > ------- > > No testing of SPARC_FS since I do not have access to and do not know where to > find the reset_new.bin and other files required. > > > Thanks, > > Andreas > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
