> On 2011-12-01 10:40:39, Andreas Hansson wrote: > > src/sim/stat_control.cc, line 56 > > <http://reviews.m5sim.org/r/922/diff/1/?file=15840#file15840line56> > > > > How about calling it simTotTicks or simAbsTicks? (Total or Absolute > > that is) > > Korey Sewell wrote: > I think that the "sim_insts" stat is a persistent one whereas the > "sim_ticks" stat is not persistent. > > That typically causes a lot of confusion. > > I would suggest that we migrate to making "sim_ticks" persistent and then > using the simCurTicks to match the reset/checkpointed stat value. > > > Nathan Binkert wrote: > I don't have much to say on specific names, but if we want to avoid > confusion, we should have unambiguous names. like sim_insts and > sim_insts_non_reset. We should be making it very clear what if any stats are > unaffected by reset() or are restored from a checkpoint.
My vote would be to make sim_ticks persistent like sim_insts and then add new stats like interval_ticks and interval_insts or sim_ticks_since_reset and sim_insts_since_reset. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/922/#review1708 ----------------------------------------------------------- On 2011-12-01 00:32:41, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/922/ > ----------------------------------------------------------- > > (Updated 2011-12-01 00:32:41) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > sim: display curTick in stats > Different from sim_ticks in that this value is restored from checkpoints and > is never reset. > Useful for aligning with framebuffer output ticks > > > Diffs > ----- > > src/sim/stat_control.cc d4e08e83f4fa > > Diff: http://reviews.m5sim.org/r/922/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
