----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/950/#review1780 -----------------------------------------------------------
Hi Andres, Thanks for taking the time to do this and submit it. I'm not a huge fan of ifdefs in the tree, so I think it would be a lot better if we created a const Addr in isa_traits.hh for every architecture and set it to either ~ULL(3) or ~ULL(0). That leaves the option open in the future for making the constant a variable if we ever get around to making a single binary that can simulate all the architectures. Thanks again, Ali - Ali On 2011-12-21 00:23:42, Anders Handler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/950/ > ----------------------------------------------------------- > > (Updated 2011-12-21 00:23:42) > > > Review request for Default. > > > Summary > ------- > > Alignment of PC is ALPHA specific, thus checks for ISA is needed. > > > Diffs > ----- > > src/cpu/pc_event.cc b28d06a175be > > Diff: http://reviews.m5sim.org/r/950/diff > > > Testing > ------- > > > Thanks, > > Anders > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
