> On 2011-12-22 11:09:20, Nathan Binkert wrote: > > Ali, can you take care of it?
I really don't want things implemented this way. The fact that Alpha is an aberration and doesn't work like it's supposed to should be codified by building support for it into all the ISAs. It should be left as an Alpha specific hack (there is plenty of precedent) and cleaned up when possible. The we won't have to rip support back out of all the other ISAs, or worry about where else this misfeature has crept into. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/950/#review1782 ----------------------------------------------------------- On 2011-12-22 10:38:02, Anders Handler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/950/ > ----------------------------------------------------------- > > (Updated 2011-12-22 10:38:02) > > > Review request for Default. > > > Summary > ------- > > Alignment of PC is ALPHA specific, thus checks for ISA is needed. > > > Diffs > ----- > > src/arch/alpha/isa_traits.hh ca98021c3f96 > src/arch/arm/isa_traits.hh ca98021c3f96 > src/arch/mips/isa_traits.hh ca98021c3f96 > src/arch/power/isa_traits.hh ca98021c3f96 > src/arch/sparc/isa_traits.hh ca98021c3f96 > src/arch/x86/isa_traits.hh ca98021c3f96 > src/cpu/pc_event.cc ca98021c3f96 > > Diff: http://reviews.m5sim.org/r/950/diff > > > Testing > ------- > > > Thanks, > > Anders > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
