----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/930/#review1826 -----------------------------------------------------------
Finally figured out why reviewboard confuses me sometimes... you can't comment on a patch and reply to a previous comment at the same time, you have to do it as two separate operations (even though you can have both the original comment and a reply in progress at the same time, leading to seemingly redundant sets of edit/discard/publish buttons). src/python/m5/SimObject.py <http://reviews.m5sim.org/r/930/#comment2351> I'm not fond of this name... it's pretty ambiguous. I'd prefer something more descriptive like 'get_config_as_dict()'. src/python/m5/simulate.py <http://reviews.m5sim.org/r/930/#comment2352> This copy-and-paste comment should be updated or deleted or something. src/python/m5/simulate.py <http://reviews.m5sim.org/r/930/#comment2353> Doesn't this create a bunch of redundant data, since you're iterating through all the objects with root.descendants() but each object's dict recursively includes all its children too? I was expecting you to just pickle root.get_dict() and that's it. - Steve On 2011-12-16 13:35:00, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/930/ > ----------------------------------------------------------- > > (Updated 2011-12-16 13:35:00) > > > Review request for Default. > > > Summary > ------- > > config: support outputing a pickle of the configuration tree > > This is useful as an input potential input to power models and visualization > tools. > > > Diffs > ----- > > src/python/m5/SimObject.py ca98021c3f96 > src/python/m5/main.py ca98021c3f96 > src/python/m5/params.py ca98021c3f96 > src/python/m5/simulate.py ca98021c3f96 > > Diff: http://reviews.m5sim.org/r/930/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
