> On 2012-01-04 16:38:33, Steve Reinhardt wrote: > > src/python/m5/SimObject.py, line 903 > > <http://reviews.m5sim.org/r/930/diff/1/?file=16302#file16302line903> > > > > I'm not fond of this name... it's pretty ambiguous. I'd prefer > > something more descriptive like 'get_config_as_dict()'.
k > On 2012-01-04 16:38:33, Steve Reinhardt wrote: > > src/python/m5/simulate.py, line 78 > > <http://reviews.m5sim.org/r/930/diff/1/?file=16305#file16305line78> > > > > This copy-and-paste comment should be updated or deleted or something. already fixed > On 2012-01-04 16:38:33, Steve Reinhardt wrote: > > src/python/m5/simulate.py, line 80 > > <http://reviews.m5sim.org/r/930/diff/1/?file=16305#file16305line80> > > > > Doesn't this create a bunch of redundant data, since you're iterating > > through all the objects with root.descendants() but each object's dict > > recursively includes all its children too? > > > > I was expecting you to just pickle root.get_dict() and that's it. you're right, I just didn't notice and root.system.blah worked fine; will fix - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/930/#review1826 ----------------------------------------------------------- On 2011-12-16 13:35:00, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/930/ > ----------------------------------------------------------- > > (Updated 2011-12-16 13:35:00) > > > Review request for Default. > > > Summary > ------- > > config: support outputing a pickle of the configuration tree > > This is useful as an input potential input to power models and visualization > tools. > > > Diffs > ----- > > src/python/m5/SimObject.py ca98021c3f96 > src/python/m5/main.py ca98021c3f96 > src/python/m5/params.py ca98021c3f96 > src/python/m5/simulate.py ca98021c3f96 > > Diff: http://reviews.m5sim.org/r/930/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
