changeset 172896057e59 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=172896057e59
description:
X86 TLB: Move a DPRINTF to its correct place
The DPRINTF for doing protection checks appears after the checks have
been
carried out. It is possible that the function returns while the checks
are
being carried, in which case the printf is missed out. This patch moves
the
DPRINTF before the checks.
diffstat:
src/arch/x86/tlb.cc | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diffs (23 lines):
diff -r 09b482ee9ae0 -r 172896057e59 src/arch/x86/tlb.cc
--- a/src/arch/x86/tlb.cc Sat Dec 31 18:44:51 2011 -0600
+++ b/src/arch/x86/tlb.cc Thu Jan 05 11:00:32 2012 -0600
@@ -328,6 +328,9 @@
DPRINTF(TLB, "Miss was serviced.\n");
#endif
}
+
+ DPRINTF(TLB, "Entry found with paddr %#x, "
+ "doing protection checks.\n", entry->paddr);
// Do paging protection checks.
bool inUser = (m5Reg.cpl == 3 &&
!(flags & (CPL0FlagBit << FlagShift)));
@@ -345,9 +348,6 @@
return new PageFault(vaddr, true, Write, inUser, false);
}
-
- DPRINTF(TLB, "Entry found with paddr %#x, "
- "doing protection checks.\n", entry->paddr);
Addr paddr = entry->paddr | (vaddr & (entry->size-1));
DPRINTF(TLB, "Translated %#x -> %#x.\n", vaddr, paddr);
req->setPaddr(paddr);
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
