> On 2012-01-10 22:37:04, Steve Reinhardt wrote: > > src/sim/system.hh, line 110 > > <http://reviews.m5sim.org/r/942/diff/3/?file=17377#file17377line110> > > > > Do we need a special function for this, as opposed to other objects > > just calling getPort("system_port")? > >
I want to get away from using getPort(const std::string&) in the C++ code all together as the "magic" names like system_port, icache_port, dcache_port etc refer to persistent and very specific ports that the objects would not be complete without. Thus, for the few objects where we get pointers to ports in the C++ code I eventually want to end up with similar functions like getDataPort() and getInstPort() on a CPU. If a port name changes that is then limited to the Python "assembly" scripts and the mapping of those names to port pointers when connecting them up. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/942/#review1891 ----------------------------------------------------------- On 2012-01-06 06:16:04, Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/942/ > ----------------------------------------------------------- > > (Updated 2012-01-06 06:16:04) > > > Review request for Default. > > > Summary > ------- > > MEM: Add the system port as a central access point > > The system port is used as a globally reachable access point to the > memory subsystem. The benefit of using an actual port is that the > usual infrastructure is used to resolve any access and thus makes the > overall system able to handle distributed memories in any > configuration, and also makes the accesses agnostic to the address > map. This patch only introduces the port and does not actually use it > for anything. > > > Diffs > ----- > > src/sim/System.py 58885e2e8a88 > src/sim/system.hh 58885e2e8a88 > src/sim/system.cc 58885e2e8a88 > > Diff: http://reviews.m5sim.org/r/942/diff > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
