> On 2012-01-10 20:03:24, Steve Reinhardt wrote: > > Interesting... my initial reaction was to object that it seemed like > > overkill to get rid of the default option entirely, but since it was only > > used it two places, it's hard to justify keeping it in there. > > > > You should also delete these two lines of MetaSimObject._new_port() which > > are what make Port defaults actually work: > > http://repo.gem5.org/gem5/file/f72bbe6b13fb/src/python/m5/SimObject.py#l276
This is now done and an up-to-date diff is added. Thanks! - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/952/#review1888 ----------------------------------------------------------- On 2012-01-11 01:53:02, Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/952/ > ----------------------------------------------------------- > > (Updated 2012-01-11 01:53:02) > > > Review request for Default. > > > Summary > ------- > > MEM: Removing the default port peer from Python ports > > In preparation for the introduction of Master and Slave ports, this > patch removes the default port parameter in the Python port and thus > forces the argument list of the Port to contain only the > description. The drawback at this point is that the config port and > dma port of PCI and DMA devices have to be connected explicitly. This > is key for future diversification as the pio and config port are > slaves, but the dma port is a master. > > > Diffs > ----- > > configs/common/FSConfig.py 508bbec99e58 > src/dev/Device.py 508bbec99e58 > src/dev/Pci.py 508bbec99e58 > src/dev/arm/RealView.py 508bbec99e58 > src/dev/pcidev.cc 508bbec99e58 > src/dev/x86/SouthBridge.py 508bbec99e58 > src/python/m5/SimObject.py 508bbec99e58 > src/python/m5/params.py 508bbec99e58 > > Diff: http://reviews.m5sim.org/r/952/diff > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
