----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/994/#review1953 -----------------------------------------------------------
I don't know all the pros and cons of doing this initialization in python vs. c++... would anyone ever want to change it? If so, it should be left in python. I'd also lean toward leaving it in python from a "if it ain't broke don't fix it" perspective. What are the benefits of moving it to c++? configs/example/fs.py <http://reviews.m5sim.org/r/994/#comment2458> Code should never be just commented out; if it's not needed any more, it should be removed. We can always resurrect it from mercurial if necessary. Also, it looks like this is the only place where setMipsOptions gets called, so you should also delete that function instead of leaving dead code in the source. src/arch/mips/isa.cc <http://reviews.m5sim.org/r/994/#comment2457> This particular line of comment is not useful (we can always use mercurial if we care where the code came from). - Steve On 2012-01-16 07:44:34, Deyuan Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/994/ > ----------------------------------------------------------- > > (Updated 2012-01-16 07:44:34) > > > Review request for Default. > > > Summary > ------- > > [--splitting the mips-fs patch--] > We can do the CP0 initialization in configCP(), then make ISA::clear() > function call the configCP() in isa.cc. > After that, the setMipsOptions() function in fs.py will be no longer needed. > > > Diffs > ----- > > configs/example/fs.py f348cf78072c > src/arch/mips/isa.cc f348cf78072c > > Diff: http://reviews.m5sim.org/r/994/diff > > > Testing > ------- > > > Thanks, > > Deyuan > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
