> On Jan. 23, 2012, 10:02 a.m., Steve Reinhardt wrote: > > src/cpu/inorder/cpu.hh, line 873 > > <http://reviews.gem5.org/r/982/diff/6/?file=21357#file21357line873> > > > > I'm still a little confused here... it seems like either we should not > > rename these stats from "committed" to "executed", or the comments are > > wrong and should say "executed" rather than "committed". > > Korey Sewell wrote: > Tony/Steve/Ali, > I'm traveling and won't be "in-place" until Wednesday. > > Please don't commit until I have a chance to review this further. > > On a first pass (Tony), make sure you are changing the correct stat > because their is an ExecutionUnit that has a "executedInsts" stat that counts > all ALU operations. Unless we are counting micro-ops as "executed" now I > think that name should stay as committed. > > The actual instructions "executed" is different than the number of > "committed" due to misspeculation/interrupts/traps/etc (especially for the > O3). > > So I'm legitimately confused. > > Please continue discussion but give me at least a day to comment before > committing. > > Thanks, > Korey > > Anthony Gutierrez wrote: > Oh sorry, I meant to fix those comments to say executed. The reason I > changed it to executed from committed is because the commit stage has a stat, > which essentially counts the same thing, and I called that committed. I can > change it back to committed, or I can change everything in the CPU to > executed across the board.
Tony, first off thanks for doing this. It's a tedious process and a lot of back/forth to get the names right (not to mention to update the regressions once we agree!). second, I think there should be a clear distinction between "executed" and "committed". Executing meaning some work done on an instruction by a functional unit and committed meaning actually retired from the CPU successfully. Keeping track of what's "executed" can be especially important for power modeling of function units. - Korey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/982/#review1982 ----------------------------------------------------------- On Jan. 22, 2012, 1:46 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/982/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2012, 1:46 p.m.) > > > Review request for Default. > > > Description > ------- > > Stats: Add stats for instructions and micro ops, both globally and per CPU. > > Adds an instructions_executed and operations_executed stat for each CPU > model. Also creates a new global stat sim_uOps which counts all operations. > Changes sim_insts to count instructions. > > > Diffs > ----- > > src/arch/noisa/cpu_dummy.hh UNKNOWN > src/cpu/base.hh UNKNOWN > src/cpu/base.cc UNKNOWN > src/cpu/inorder/cpu.hh UNKNOWN > src/cpu/inorder/cpu.cc UNKNOWN > src/cpu/inorder/inorder_dyn_inst.hh UNKNOWN > src/cpu/o3/commit.hh UNKNOWN > src/cpu/o3/commit_impl.hh UNKNOWN > src/cpu/o3/cpu.hh UNKNOWN > src/cpu/o3/cpu.cc UNKNOWN > src/cpu/simple/base.hh UNKNOWN > src/cpu/simple/base.cc UNKNOWN > src/cpu/thread_state.hh UNKNOWN > src/cpu/thread_state.cc UNKNOWN > src/sim/stat_control.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/982/diff/diff > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
