----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/982/#review2089 -----------------------------------------------------------
Ship it! My only concern was about some of the naming in the InOrder model, and I can't see the resolution there because reviewboard is giving errors on those specific diffs. However, as long as that's resolved to everyone else's satisfaction, then I'm fine with it. I agree it would be good to have this committed. - Steve Reinhardt On Feb. 5, 2012, 12:10 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/982/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2012, 12:10 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8816:282c8eab17a3 > --------------------------- > add separate stats for insts/ops both globally and per cpu > > > Diffs > ----- > > src/arch/noisa/cpu_dummy.hh UNKNOWN > src/cpu/base.hh UNKNOWN > src/cpu/base.cc UNKNOWN > src/cpu/inorder/cpu.hh UNKNOWN > src/cpu/inorder/cpu.cc UNKNOWN > src/cpu/inorder/inorder_dyn_inst.hh UNKNOWN > src/cpu/o3/commit.hh UNKNOWN > src/cpu/o3/commit_impl.hh UNKNOWN > src/cpu/o3/cpu.hh UNKNOWN > src/cpu/o3/cpu.cc UNKNOWN > src/cpu/simple/base.hh UNKNOWN > src/cpu/simple/base.cc UNKNOWN > src/cpu/thread_state.hh UNKNOWN > src/cpu/thread_state.cc UNKNOWN > src/sim/stat_control.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/982/diff/diff > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
