On 01/28/12 16:04, Ali Saidi wrote: > On Jan 28, 2012, at 7:20 AM, Gabe Black wrote: > >> I notice there are still remnants of old port types floating around the >> code base. For instance, there are lots of declarations of classes that >> no longer exist and aren't actually used. grepping for FunctionalPort, >> for instance, comes up with a handful of examples. It also shows that >> FunctionalPort is still used in SPARC's vtophys.hh, likely meaning that >> SPARC_FS won't compile now. >> >> It would be great if someone (I nominate Andreas) goes and cleans up the >> cruft. It's very important that somebody fixes SPARC_FS if it's indeed >> broken. Since I don't know how the new port stuff is supposed to work, I >> again nominate Andreas. >> >> Gabe > The SPARC_FS regression still passes. They're just forward declarations for > the FunctionalPort class and a prototype that doesn't actually exist in the > source code (not to say that it they shouldn't be removed). > > Ali > > > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev
Yeah, I saw that too. We should clean that up along with all the class declarations. Gabe _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
