----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1021/#review2076 -----------------------------------------------------------
util/tracediff <http://reviews.gem5.org/r/1021/#comment2564> Don't you want to fold the if & while together into: while (@ARGV >= 1 && ($ARGV[0] eq '-n'|| $ARGV[0] eq '-p')) otherwise I think you could have a problem if someone ran: ./tracediff -n because the while loop will iterate checking $ARGV[0] even if all the args have been consumed. - Steve Reinhardt On Feb. 3, 2012, 9:15 a.m., William Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1021/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2012, 9:15 a.m.) > > > Review request for Default. > > > Description > ------- > > DEBUG: Added a path option to tracediff > > Added a path option '-p' to tracediff, this is useful when the default cwd > quota/space is not large enough to hold all the traces. > > > Diffs > ----- > > util/tracediff 8bdfb1947cff > > Diff: http://reviews.gem5.org/r/1021/diff/diff > > > Testing > ------- > > Ran tracediff okay: ./util/tracediff -p ~/scratch 'build/ARM_FS| > build/ARM_FS_PASS#/gem5.opt' --debug-flags=Exec,Cache,Bus > --trace-start=66488126500 -re tests/run.py > build/ARM_FS/tests/opt/long/10.linux-boot/arm/linux/realview-o3-dual > > > Thanks, > > William Wang > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
