----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1050/#review2155 -----------------------------------------------------------
configs/common/Benchmarks.py <http://reviews.gem5.org/r/1050/#comment2647> the default shouldn't change. configs/common/FSConfig.py <http://reviews.gem5.org/r/1050/#comment2648> Addr('3GB')? that constant is not reasonable configs/common/FSConfig.py <http://reviews.gem5.org/r/1050/#comment2649> I believe that real x86 systems map the entire space and then re-map the 3-4GB range somewhere else. configs/ruby/MESI_CMP_directory.py <http://reviews.gem5.org/r/1050/#comment2650> This seems like a kludge src/mem/physical.cc <http://reviews.gem5.org/r/1050/#comment2651> this shouldn't be commented out, it should be fixed. - Ali Saidi On Feb. 15, 2012, 3:07 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1050/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2012, 3:07 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8852:3c033ec380b5 > --------------------------- > Extend physical memory beyond 4GB > The patch adds a list of address ranges to the physical memory instead of > having a single address range. It has been tested with X86 architecture so > far. > > > Diffs > ----- > > configs/common/Benchmarks.py ef8630054b5e > configs/common/FSConfig.py ef8630054b5e > configs/ruby/MESI_CMP_directory.py ef8630054b5e > configs/ruby/Ruby.py ef8630054b5e > src/mem/PhysicalMemory.py ef8630054b5e > src/mem/dram.cc ef8630054b5e > src/mem/physical.hh ef8630054b5e > src/mem/physical.cc ef8630054b5e > > Diff: http://reviews.gem5.org/r/1050/diff/diff > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
