----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1054/#review2167 -----------------------------------------------------------
Don't just copy in the Alpha implementations. Either figure out what ARM should really be using, make them panic, or leave them unimplemented. src/arch/arm/stacktrace.cc <http://reviews.gem5.org/r/1054/#comment2655> Is this value correct, or is it just what Alpha used? src/arch/arm/stacktrace.cc <http://reviews.gem5.org/r/1054/#comment2654> I'm assuming this is copied from Alpha. It's probably not appropriate for ARM. - Gabe Black On Feb. 20, 2012, 5:17 p.m., Anthony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1054/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2012, 5:17 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8849:bdd7f776a182 > --------------------------- > ARM: implement the ProcessInfo methods > > > Diffs > ----- > > src/arch/arm/stacktrace.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/1054/diff/diff > > > Testing > ------- > > > Thanks, > > Anthony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
