----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1056/#review2181 -----------------------------------------------------------
Most of my issues are with the comments and not with the code, so that's a pretty good sign... src/mem/cache/cache_impl.hh <http://reviews.gem5.org/r/1056/#comment2668> "not" should be "note", might want to add that we don't have a functionalSnoop method because functional requests do the same thing regardless of which side they come in src/mem/tport.hh <http://reviews.gem5.org/r/1056/#comment2667> The default for label should be something generic but meaningful, like "SimpleTimingPort" src/mem/tport.cc <http://reviews.gem5.org/r/1056/#comment2664> Does having a constructor parameter with the same name as a member even work? I'm surprised if it does... src/mem/tport.cc <http://reviews.gem5.org/r/1056/#comment2666> I think this comment is a little misleading... I'd say "if we are waiting on a retry, there's no need to schedule sendEvent" src/mem/tport.cc <http://reviews.gem5.org/r/1056/#comment2665> Missing part of this comment src/mem/tport.cc <http://reviews.gem5.org/r/1056/#comment2663> Should "not" be "note" here? Also should "do not" be "may not"? - Steve Reinhardt On Feb. 21, 2012, 3:22 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1056/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2012, 3:22 a.m.) > > > Review request for Default. > > > Description > ------- > > MEM: Simplify cache ports preparing for master/slave split > > This patch splits the two cache ports into a master (memory-side) and > slave (cpu-side) subclass of port with slightly different > functionality. For example, it is only the CPU-side port that blocks > incoming requests, and only the memory-side port that schedules send > events outside of what the transmit list dictates. > > This patch simplifies the two classes by relying further on > SimpleTimingPort and also generalises the latter to better accommodate > the changes (introducing trySendTiming and scheduleSend). The > memory-side cache port overrides sendDeferredPacket to be able to not > only send responses from the transmit list, but also send requests > based on the MSHRs. > > A follow on patch further simplifies the SimpleTimingPort and the > cache ports. > > > Diffs > ----- > > src/mem/cache/base.hh 2629f0b99e8d > src/mem/cache/base.cc 2629f0b99e8d > src/mem/cache/cache.hh 2629f0b99e8d > src/mem/cache/cache_impl.hh 2629f0b99e8d > src/mem/tport.hh 2629f0b99e8d > src/mem/tport.cc 2629f0b99e8d > > Diff: http://reviews.gem5.org/r/1056/diff/diff > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
