In a patch not far away this will be a MasterPort, and I suggest deferring the "fix" until then and make it: MasterPort *getMasterPort() to match the rest of the file.
Andreas -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Ali Saidi Sent: 01 March 2012 18:15 To: [email protected] Subject: Re: [gem5-dev] changeset in gem5: x86: Fix x86 TLB and Walker I believe the options were Port* or *getport but there was no option for Port * getport Ali On 01.03.2012 12:01, Nilay Vaish wrote: > Did we not decide on maintaining uniformity with in a single file? > > -- > Nilay > > On Thu, 1 Mar 2012, Ali Saidi wrote: > >> I don't think this one meets the style guidelines. On 01.03.2012 11:40, Nilay Vaish wrote: >> >>> --- a/src/arch/x86/tlb.hh Thu Mar 01 >> 11:37:02 2012 -0600 >> >>> +++ b/src/arch/x86/tlb.hh Thu Mar 01 11:37:03 2012 >> -0600 virtual void unserialize(Checkpoint *cp, const std::string §ion); ___________________________________ >> >>> t:#1010ff 2px solid; margin-left >> 00%">[email protected] [1] ht >> >>> list [email protected] >> f="http://m5sim.org/mailman/listinfo/gem5-dev";>http://m5sim.org/mailman/listinfo/gem5-dev >> >>> > > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev Links: ------ [1] mailto:[email protected] _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
