> On March 25, 2012, 10:10 a.m., Ali Saidi wrote: > > configs/example/se.py, line 86 > > <http://reviews.gem5.org/r/1115/diff/1/?file=25079#file25079line86> > > > > Anyone know why we did this as opposed to import Options before? Is it > > something to do with relative path import in python 2.4 vs 2.5? > >
No clue... I went back to where the file was created (http://repo.gem5.org/gem5/rev/49e674f2fb5d), and the Simulation.py file was created at the same time but it was imported rather than exec'd. So it's probably just an accident of history. - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1115/#review2371 ----------------------------------------------------------- On March 24, 2012, 1:33 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1115/ > ----------------------------------------------------------- > > (Updated March 24, 2012, 1:33 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8919:6042ba0e2f60 > --------------------------- > Config: Change the way options are added > I am not too happy with the way options are added in files se.py and fs.py > currently. This patch moves all the options to the file Options.py, functions > from which are called when required. > > > Diffs > ----- > > configs/common/Options.py 7d95b650c9b6 > configs/example/fs.py 7d95b650c9b6 > configs/example/ruby_fs.py 7d95b650c9b6 > configs/example/se.py 7d95b650c9b6 > tests/configs/memtest-ruby.py 7d95b650c9b6 > tests/configs/rubytest-ruby.py 7d95b650c9b6 > tests/configs/simple-timing-mp-ruby.py 7d95b650c9b6 > tests/configs/simple-timing-ruby.py 7d95b650c9b6 > > Diff: http://reviews.gem5.org/r/1115/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
