> On March 25, 2012, 6:29 p.m., Steve Reinhardt wrote: > > configs/common/Options.py, line 132 > > <http://reviews.gem5.org/r/1115/diff/1/?file=25076#file25076line132> > > > > This bit of code to set m5_root seems like overkill since m5_root is > > only used to set a default path for cmd that I expect is never used. I'd > > be in favor of not having a default for cmd and then getting rid of these > > lines. > > Nilay Vaish wrote: > Since we don't have any check in place in se.py on the value of cmd, it is > necessary that cmd has a default value. > > Steve Reinhardt wrote: > We could certainly add such a check. It's not a big deal either way, I > guess.
I have added a check to se.py. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1115/#review2375 ----------------------------------------------------------- On March 27, 2012, 4:38 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1115/ > ----------------------------------------------------------- > > (Updated March 27, 2012, 4:38 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8921:9328fdaf0992 > --------------------------- > Config: Change the way options are added > I am not too happy with the way options are added in files se.py and fs.py > currently. This patch moves all the options to the file Options.py, functions > from which are called when required. > > > Diffs > ----- > > configs/example/se.py c1366a30d5eb > tests/configs/memtest-ruby.py c1366a30d5eb > tests/configs/rubytest-ruby.py c1366a30d5eb > tests/configs/simple-timing-mp-ruby.py c1366a30d5eb > tests/configs/simple-timing-ruby.py c1366a30d5eb > configs/example/fs.py c1366a30d5eb > configs/example/ruby_fs.py c1366a30d5eb > configs/common/Options.py c1366a30d5eb > > Diff: http://reviews.gem5.org/r/1115/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
