----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1124/ -----------------------------------------------------------
Review request for Default. Description ------- Ruby: Use MasterPort base-class pointers where possible This patch simplifies future patches by changing the pointer type used in a number of the Ruby testers to use MasterPort instead of using a derived CpuPort class. There is no reason for using the more specialised pointers, and there is no longer a need to do any casting. Diffs ----- src/cpu/testers/directedtest/InvalidateGenerator.cc 570b44fe6e04 src/cpu/testers/directedtest/RubyDirectedTester.hh 570b44fe6e04 src/cpu/testers/directedtest/SeriesRequestGenerator.cc 570b44fe6e04 src/cpu/testers/rubytest/Check.cc 570b44fe6e04 src/cpu/testers/rubytest/RubyTester.hh 570b44fe6e04 Diff: http://reviews.gem5.org/r/1124/diff/ Testing ------- util/regress all passing (disregarding t1000 and eio) Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
