----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1124/ -----------------------------------------------------------
(Updated April 7, 2012, 5:44 a.m.) Review request for Default. Description (updated) ------- Ruby: Use MasterPort base-class pointers where possible This patch simplifies future patches by changing the pointer type used in a number of the Ruby testers to use MasterPort instead of using a derived CpuPort class. There is no reason for using the more specialised pointers, and there is no longer a need to do any casting. With the latest changes to the tester, organising ports as readers and writes, things got a bit more complicated, and the "type" now had to be removed to be able to fall back to using MasterPort rather than CpuPort. Diffs (updated) ----- src/cpu/testers/directedtest/InvalidateGenerator.cc a47fd7c2d44e src/cpu/testers/directedtest/RubyDirectedTester.hh a47fd7c2d44e src/cpu/testers/directedtest/SeriesRequestGenerator.cc a47fd7c2d44e src/cpu/testers/rubytest/Check.cc a47fd7c2d44e src/cpu/testers/rubytest/RubyTester.hh a47fd7c2d44e src/cpu/testers/rubytest/RubyTester.cc a47fd7c2d44e Diff: http://reviews.gem5.org/r/1124/diff/ Testing ------- util/regress all passing (disregarding t1000 and eio) Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
